On Tue, 5 Apr 2016 00:57:16 +0000 "Lu, Wenzhuo" <wenzhuo.lu at intel.com> wrote:
> Hi Stephen, > > > -----Original Message----- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Tuesday, April 5, 2016 12:14 AM > > To: Zhang, Helin; Ananyev, Konstantin > > Cc: dev at dpdk.org; Stephen Hemminger > > Subject: [dpdk-dev] [PATCH] ixgbe: cleanup whitespace and formatting issues > > > > This driver was one of the originals and has lots of little whitespace > > issues. > > > > PS: I know Intel doesn't like whitespace changes, there is never a good time > > to do this, but no resuliting binary changes and it is unlikely that more > > changes to this driver will occur this late in release cycle. > > > > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org> > Thanks for this patch. I think it's good to make the format better :) > But there's some checkpatch error and warnings, like this, > ERROR: "foo* bar" should be "foo *bar" > #508: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4256: > +ixgbe_uc_hash_table_set(struct rte_eth_dev *dev, struct ether_addr* mac_addr, > I didn't fix all the checkpatch errors, just the easy ones.