Re: Re: [PATCH v5 3/3] riscv: override machine_args only when default

[孙越池]

Okay, they have been updated in v6.


> -----原始邮件-----
&gt; 发件人: "Stanisław Kardach" <stanislaw.kard...@gmail.com>
&gt; 发送时间: 2025-06-27 10:31:15 (星期五)
&gt; 收件人: u...@foxmail.com
&gt; 抄送: dev@dpdk.org, "Sun Yuechi" <sunyue...@iscas.ac.cn>, "Bruce Richardson" 
<bruce.richard...@intel.com>
&gt; 主题: Re: [PATCH v5 3/3] riscv: override machine_args only when default
&gt; 
&gt; On Wed, Jun 11, 2025 at 5:23 PM <u...@foxmail.com> wrote:
&gt; &gt;
&gt; &gt; From: Sun Yuechi <sunyue...@iscas.ac.cn>
&gt; &gt;
&gt; &gt; Support using -Dcpu_instruction_set=rv64gcv to enable V extension.
&gt; &gt;
&gt; &gt; Signed-off-by: Sun Yuechi <sunyue...@iscas.ac.cn>
&gt; &gt; ---
&gt; &gt;  config/riscv/meson.build | 2 ++
&gt; &gt;  1 file changed, 2 insertions(+)
&gt; &gt;
&gt; &gt; diff --git a/config/riscv/meson.build b/config/riscv/meson.build
&gt; &gt; index e3694cf2e6..1036a86d05 100644
&gt; &gt; --- a/config/riscv/meson.build
&gt; &gt; +++ b/config/riscv/meson.build
&gt; &gt; @@ -111,6 +111,7 @@ arch_config = arch_config[arch_id]
&gt; &gt;  # Concatenate flags respecting priorities.
&gt; &gt;  dpdk_flags = flags_common + vendor_config['flags'] + 
arch_config.get('flags', [])
&gt; &gt;
&gt; &gt; +if (cpu_instruction_set == 'rv64gc')
&gt; Perhaps instead of removing full flag customization, we should skip
&gt; the -march flag within foreach if cpu_instruction_set!='rv64gc'.
&gt; Reason being that just 'rv64gc' doesn't mean the default. Look at
&gt; SiFive configs - they have -march=rv64gc but -mtune specific to those
&gt; boards.
&gt; &gt;  # apply supported machine args
&gt; &gt;  machine_args = [] # Clear previous machine args
&gt; &gt;  foreach flag: arch_config['machine_args']
&gt; &gt; @@ -118,6 +119,7 @@ foreach flag: arch_config['machine_args']
&gt; &gt;          machine_args += flag
&gt; &gt;      endif
&gt; &gt;  endforeach
&gt; &gt; +endif
&gt; Small nit - there's an indentation level missing around #if-#endif
&gt; 
&gt; &gt;
&gt; &gt;  # check if we can do buildtime detection of extensions supported by 
the target
&gt; &gt;  riscv_extension_macros = false
&gt; &gt; --
&gt; &gt; 2.49.0
&gt; &gt;
</sunyue...@iscas.ac.cn></sunyue...@iscas.ac.cn></u...@foxmail.com></bruce.richard...@intel.com></sunyue...@iscas.ac.cn></stanislaw.kard...@gmail.com>