On Mon, 7 Jul 2025 12:17:51 +0100 Bruce Richardson <bruce.richard...@intel.com> wrote:
> Two small improvements for the cmdline file processing in testpmd. > > * Now that we support multiple files, change the prompt to indicate what > file is currently being processed, and just print an EOF message when > done. > * When not echoing, the "Read" verb in the message "Read CLI commands..." > is a little ambiguous, as it could mean "I have read", or "Go and read", > i.e. job done or job about to start. Tweak the text to "Finished reading" > which is unambiguous. > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > --- > > Owing to limitations of whats available on windows, e.g. no basename > function, the windows implementation prints N characters from the end of > the filename, if its too long. While I don't think this is as good as the > basename version used on Linux/Unix, if we want to have common code, we can > just use that as a common version everywhere and drop the basename version. I would prefer just having basename() wrapper like other helpers we have already for Windows. Get from FreeBSD or other BSD licensed source (or write your own). Having two #ifdefs creates needless platform difference here.
