On Fri, 1 Aug 2025 12:21:02 +0200 Tomasz Duszynski <tduszyn...@marvell.com> wrote:
> Add a dummy rte_pmu_read() definition for chkincs when > ALLOW_EXPERIMENTAL_API is not defined to suppress warnings from > use of experimental APIs in tracepoints. > > Fixes: 960c43184c4d ("pmu: introduce library for reading PMU events") > > Signed-off-by: Tomasz Duszynski <tduszyn...@marvell.com> > --- > lib/pmu/rte_pmu.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/pmu/rte_pmu.h b/lib/pmu/rte_pmu.h > index 57b634ecd8..84a5d522d1 100644 > --- a/lib/pmu/rte_pmu.h > +++ b/lib/pmu/rte_pmu.h > @@ -232,6 +232,10 @@ rte_pmu_read(unsigned int index) > > return __rte_pmu_read_userpage(group->mmap_pages[index]); > } > +/* quiesce warnings produced by chkincs */ > +#ifndef ALLOW_EXPERIMENTAL_API > +#define rte_pmu_read(pc) ({ RTE_SET_USED(pc); 0; }) > +#endif Seems like an awkward solution I would rather that fix chkincs or restructure this. The way you are doing it will cause the checks for use of experimental API to not work.