In the current implementation of Checksum Offload, the variables
is_L4 and is_IP are not initialized outside of the loop that
checks the received packet, so if the packet is dropped these
variables cause a NameError in the verification steps.
Add a line that sets these variables to None prior to the check,
then verifies they are not None directly after.
Fixes: 8c9a7471a0e6 ("dts: add checksum offload test suite")
Signed-off-by: Dean Marx <dm...@iol.unh.edu>
---
dts/tests/TestSuite_checksum_offload.py | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/dts/tests/TestSuite_checksum_offload.py
b/dts/tests/TestSuite_checksum_offload.py
index b03c3d46ed..d411af70a9 100644
--- a/dts/tests/TestSuite_checksum_offload.py
+++ b/dts/tests/TestSuite_checksum_offload.py
@@ -85,10 +85,15 @@ def send_packet_and_verify_checksum(
testpmd.start()
self.send_packet_and_capture(packet=packet)
verbose_output = testpmd.extract_verbose_output(testpmd.stop())
+ is_IP = is_L4 = None
for testpmd_packet in verbose_output:
if testpmd_packet.l4_dport == id:
is_IP = PacketOffloadFlag.RTE_MBUF_F_RX_IP_CKSUM_GOOD in
testpmd_packet.ol_flags
is_L4 = PacketOffloadFlag.RTE_MBUF_F_RX_L4_CKSUM_GOOD in
testpmd_packet.ol_flags
+ self.verify(
+ is_IP is not None and is_L4 is not None,
+ "Test packet was dropped when it should have been received.",
+ )
self.verify(is_L4 == good_L4, "Layer 4 checksum flag did not match
expected checksum flag.")
self.verify(is_IP == good_IP, "IP checksum flag did not match expected
checksum flag.")
--
2.50.1
