On Thu, Aug 07, 2025 at 08:08:26PM +0100, Bruce Richardson wrote: > The ice driver expects the first, or outer, VLAN tag in a packet to be > written to the L2TAG1 field of the descriptor, as configured by the > l2tsel field when configuring the queue context initially for the > device. However, when configuring the actual VLAN or QinQ strip > behaviour, that l2tsel field was changed, sending the single/outer vlan > tag to the L2TAG2 field in the descriptor. This meant that it was not > getting picked up correctly by the Rx paths. > > This issue has been around for a long time, but was previously > partially hidden by the issue fixed in [1], since due to that bug, > the l2tsel field was not getting overridden in the single-queue case > (since the single queue was the final queue). > > Fix the issue by just removing the code updating the l2tsel field, and > leave it as set by default in the initial queue configuration. > > [1] https://github.com/DPDK/dpdk/commit/4cd8c72f6 > > Fixes: de5da9d16430 ("net/ice: support double VLAN") > Cc: sta...@dpdk.org > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > Acked-by: Ciara Loftus <ciara.lof...@intel.com> > --- Applied to dpdk-next-net-intel.
/Bruce
