Looks mostly fine but as noted in the earlier patch, should be * not -.
Just one small issue:
On 07/08/2025 15:50, Dean Marx wrote:
diff --git a/dts/tests/TestSuite_mtu.py b/dts/tests/TestSuite_mtu.py
index d5b3fe02af..0d36f18b00 100644
--- a/dts/tests/TestSuite_mtu.py
+++ b/dts/tests/TestSuite_mtu.py
@@ -127,35 +127,35 @@ def assess_mtu_boundary(self, testpmd_shell: TestPmdShell,
mtu: int) -> None:
def test_runtime_mtu_updating_and_forwarding(self) -> None:
"""Verify runtime MTU adjustments and assess packet forwarding
behavior.
- Test:
- * Start TestPMD in a paired topology.
- * Set port MTU to 1500.
- * Send packets of 1491, 1500 and 1509 bytes.
- * Verify the first two packets are forwarded and the last is
dropped.
-
- * Set port MTU to 2400.
- * Send packets of 1491, 1500 and 1509 bytes.
- * Verify all three packets are forwarded.
- * Send packets of 2391, 2400 and 2409 bytes.
- * Verify the first two packets are forwarded and the last is
dropped.
-
- * Set port MTU to 4800.
- * Send packets of 1491, 1500 and 1509 bytes.
- * Verify all three packets are forwarded.
- * Send packets of 4791, 4800 and 4809 bytes.
- * Verify the first two packets are forwarded and the last is
dropped.
-
- * Set port MTU to 9000.
- * Send packets of 1491, 1500 and 1509 bytes.
- * Verify all three packets are forwarded.
- * Send packets of 8991, 9000 and 9009 bytes.
- * Verify the first two packets are forwarded and the last is
dropped.
+ Steps:
+ - Start TestPMD in a paired topology.
+ - Set port MTU to 1500.
+ - Send packets of 1491, 1500 and 1509 bytes.
+ Verify the first two packets are forwarded and the last is
dropped.
Looks like you broke the second level list by removing the *. The format
of the original looked fine. Same for the below> +
+ - Set port MTU to 2400.
+ - Send packets of 1491, 1500 and 1509 bytes.
+ Verify all three packets are forwarded.
+ - Send packets of 2391, 2400 and 2409 bytes.
+ Verify the first two packets are forwarded and the last is
dropped.
+
+ - Set port MTU to 4800.
+ - Send packets of 1491, 1500 and 1509 bytes.
+ Verify all three packets are forwarded.
+ - Send packets of 4791, 4800 and 4809 bytes.
+ Verify the first two packets are forwarded and the last is
dropped.
+
+ - Set port MTU to 9000.
+ - Send packets of 1491, 1500 and 1509 bytes.
+ Verify all three packets are forwarded.
+ - Send packets of 8991, 9000 and 9009 bytes.
+ Verify the first two packets are forwarded and the last is
dropped.
Verify:
- * Verifies the successful forwarding of packets via a search for
an inserted payload.
+ - Verifies the successful forwarding of packets via a search for
an inserted payload.
If the payload is found, the packet was transmitted
successfully. Otherwise, the
packet is considered dropped.
- * Verify that standard MTU packets forward, in addition to packets within the limits of
+ - Verify that standard MTU packets forward, in addition to packets
within the limits of
an MTU size set during runtime.
"""
with TestPmdShell(tx_offloads=0x8000, mbuf_size=[JUMBO_MTU + 200]) as
testpmd:
