> -----Original Message----- > From: Topel, Bjorn > Sent: Tuesday, April 19, 2016 2:47 AM > To: Zhang, Helin <helin.zhang at intel.com>; David Marchand > <david.marchand at 6wind.com> > Cc: dev at dpdk.org; Wu, Jingjing <jingjing.wu at intel.com> > Subject: RE: [dpdk-dev] [PATCH] i40evf: Ignore disabled HW CRC strip for > Linux PF > hosts > > >> Not sure this is the right way to handle it. The driver should > >> return an error rather than silently discard what the application > >> asked. > > > > I also think it should return an error with checking if the host is > > kernel driver, and crc strip is disabled in VF. Thank you David! > > Thanks for reviewing my patch, Helin and David. > > I agree that it's subtle to ignore the error, and just log the error. This is > how > ixgbevf behaves (refer to ixgbevf_dev_configure), so I figured that i40evf > should > behave analogous. > > I'll submit a v2 of the patch that returns an EINVAL and logs the failure. > > Would it make sense to change the ixgbevf_dev_configure as well, in a separate > patch? Yes, I agree with you that ixgbe and i40e should be consistent. Thank you!
/Helin > > > >> --------------------------------------------------------------------- > >> - > >> Intel Sweden AB > >> Registered Office: Isafjordsgatan 30B, 164 40 Kista, Stockholm, > >> Sweden Registration Number: 556189-6027 > >> > >> This e-mail and any attachments may contain confidential material for > >> the sole use of the intended recipient(s). Any review or distribution > >> by others is strictly prohibited. If you are not the intended > >> recipient, please contact the sender and delete all copies. > > > > Please, remove this. > > Noted. Will make sure to fix that for future revisions. Thanks! > > > Bj?rn