Comments inline:
Internal Use - Confidential -----Original Message----- From: Thomas Monjalon <tho...@monjalon.net> Sent: Tuesday, August 19, 2025 4:36 AM To: Bathija, Pravin <pravin.bath...@dell.com> Cc: dev@dpdk.org; pravin.m.bathija....@gmail.com; Maxime Coquelin <maxime.coque...@redhat.com>; Chenbo Xia <chen...@nvidia.com>; David Marchand <david.march...@redhat.com>; Bruce Richardson <bruce.richard...@intel.com> Subject: Re: [PATCH 0/3] vhost_user: configure memory slots [EXTERNAL EMAIL] Comments inline 12/08/2025 04:33, Pravin M Bathija: > - add protocol feature support add and removal of memory regions/slots > dynamically. > - this patch set has been tested with multiple instances of fio What is "fio"? Fio is an open-source tool to test various I/O work-loads on disks and file systems. https://github.com/axboe/fio > connected via libblkio to spdk target backed unix domain socket. > - please apply this this patch-set to dpdk mainline as well as version > 25.03.0. As mentionned previously, we don't plan to maintain 25.03. I understand you need it for SPDK, but I think SPDK should rely only on LTS branches. Is there a specific reason why 25.03 is required in SPDK? > v2: > - fixed warnings with e-mail address > - fixed warnings with typos > - there is a warning about __rte_packed_begin not being in pair with > __rte_packed_end which on reading the code turns out to be false. It > is an anomaly of how git-format generates the patch and how > check-patch checks it. When sending a v2, please use -v2 so it is reflected in the email subject. > Pravin M Bathija (3): > mailmap: add user > vhost_user: configure memory slots > vhost_user: support for memory regions > > .mailmap | 1 + > lib/vhost/rte_vhost.h | 4 + > lib/vhost/vhost_user.c | 325 > +++++++++++++++++++++++++++++++++++------ > lib/vhost/vhost_user.h | 10 ++ > 4 files changed, 296 insertions(+), 44 deletions(-)
