On Mon, Sep 15, 2025 at 10:53:08AM -0700, Stephen Hemminger wrote: > On Fri, 12 Sep 2025 17:02:10 +0100 > Bruce Richardson <[email protected]> wrote: > > > When dealing with multi-segment packets, there are separate offload > > flags which should be enabled on Rx (scattered flag) and on Tx > > (multi-segment flag). Print warnings on testpmd startup if we detect a > > situation where we suspect the user is missing these flags, e.g. we > > allow scattered packets on Rx, but not on Tx. > > > > Signed-off-by: Bruce Richardson <[email protected]> > > --- > > Should also check for RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT which should require > multiple segment support. > > Could testpmd also check the descriptor limits of the device? > Does it validate nb_seg_max for TSO, and nb_mtu_seg_max for all cases? >
There are indeed lots of other checks that testpmd could do, but I'm not going to try and implement them all in this one patch. The main reason for doing these particular checks is that it's comparatively easy to enable scattered support on Rx - since there is an explicit flag for it, and some drivers enable the support automatically if they detect an MTU > mbuf size - but it's awkward to enable on Tx, since you have to manually specify the Tx offloads flags. /Bruce
