On Wed, 1 Oct 2025 at 08:45, David Marchand <[email protected]> wrote: > > As explained in patch 8, the current headers check can not catch > issues when a public header includes an internal header. > > Patch 1-5 fixes have not been marked as backport material as those bugs > seems minor/easy to fix externally (by either including missing headers, > or enabling enable_driver_sdk option). > > > -- > David Marchand > > Changes since v6: > - a rabbit told me I should fix driver headers include path: > https://github.com/david-marchand/dpdk/pull/2#discussion_r2390690589, > > Changes since v5: > - added headers staging cleanup, > > Changes since v4: > - reworked headers install, > - fixed issue in ARM memcpy header, > - further simplified the header check modifications, > > Changes since v3: > - narrowed down the changes under a check on check_includes= option, > - moved the staging directories under buildtools/chkincs, > > Changes since v2: > - major rework, dropping the makefile approach, and instead copying > headers to a staging directory used by the check, > - rebased, > - dropped changes on raw cnxk drivers and disabled the associated > build warning in the headers check, > > David Marchand (9): > baseband/acc: fix exported header > drivers: drop export of driver headers > eventdev: do not include driver header in DMA adapter > gpudev: fix driver header for Windows > drivers: fix some exported headers > eal/arm: fix C++ build for 32-bit memcpy > build: factorize headers installation > buildtools/chkincs: use a staging directory for headers > power: separate public and driver headers > > buildtools/chkincs/meson.build | 68 +++++++++++++++---- > .../chkincs/staging/drivers/meson.build | 13 ++++ > buildtools/chkincs/staging/meson.build | 43 ++++++++++++ > buildtools/chkincs/staging/stage-headers.py | 50 ++++++++++++++ > config/meson.build | 3 +- > devtools/checkpatches.sh | 8 +++ > drivers/baseband/acc/meson.build | 2 +- > drivers/bus/vmbus/rte_vmbus_reg.h | 6 ++ > drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h | 2 + > drivers/meson.build | 7 +- > drivers/net/dpaa/rte_pmd_dpaa.h | 2 + > drivers/net/intel/iavf/rte_pmd_iavf.h | 6 ++ > drivers/net/mlx5/rte_pmd_mlx5.h | 3 + > drivers/net/txgbe/meson.build | 2 +- > drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h | 2 + > drivers/raw/ntb/rte_pmd_ntb.h | 2 + > lib/bbdev/meson.build | 14 ++-- > lib/eal/arm/include/meson.build | 3 +- > lib/eal/arm/include/rte_memcpy_32.h | 6 +- > lib/eal/include/meson.build | 3 +- > lib/eal/loongarch/include/meson.build | 3 +- > lib/eal/ppc/include/meson.build | 3 +- > lib/eal/riscv/include/meson.build | 3 +- > lib/eal/x86/include/meson.build | 6 +- > lib/ethdev/meson.build | 6 +- > lib/eventdev/rte_event_dma_adapter.h | 2 +- > lib/gpudev/gpudev.c | 1 + > lib/gpudev/gpudev_driver.h | 4 +- > lib/meson.build | 10 +-- > lib/mldev/meson.build | 5 +- > lib/power/meson.build | 7 +- > lib/power/power_cpufreq.h | 14 +--- > lib/power/power_uncore_ops.h | 1 + > lib/power/rte_power_cpufreq.c | 2 +- > lib/power/rte_power_cpufreq.h | 15 +++- > lib/power/rte_power_uncore.c | 2 +- > lib/power/rte_power_uncore.h | 3 +- > lib/rawdev/meson.build | 3 +- > lib/regexdev/meson.build | 3 +- > lib/security/meson.build | 3 +- > meson.build | 21 ++++-- > 41 files changed, 276 insertions(+), 86 deletions(-) > create mode 100644 buildtools/chkincs/staging/drivers/meson.build > create mode 100644 buildtools/chkincs/staging/meson.build > create mode 100755 buildtools/chkincs/staging/stage-headers.py
Series applied, thanks for the reviews. -- David Marchand
