On Thu, Oct 16, 2025 at 5:44 PM Maxime Coquelin <[email protected]> wrote: > > Hi Nicolas, > > On Wed, May 28, 2025 at 12:36 AM Nicolas Chautru > <[email protected]> wrote: > > > > Add the details of the operation parameters into > > trace when that operation is rejected by the PMD. > > > > Signed-off-by: Nicolas Chautru <[email protected]> > > --- > > drivers/baseband/acc/acc_common.h | 1 + > > drivers/baseband/acc/vrb_trace.h | 4 ++-- > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/baseband/acc/acc_common.h > > b/drivers/baseband/acc/acc_common.h > > index 4880444450..3d411cd25f 100644 > > --- a/drivers/baseband/acc/acc_common.h > > +++ b/drivers/baseband/acc/acc_common.h > > @@ -700,6 +700,7 @@ acc_error_log(struct acc_queue *q, void *op, uint8_t > > acc_error_idx, const char * > > > > rte_bbdev_vrb_trace_error(0, rte_bbdev_op_type_str(q->op_type), > > acc_error_string[acc_error_idx]); > > + rte_bbdev_ops_trace(op, q->op_type); > > > > va_end(args); > > } > > diff --git a/drivers/baseband/acc/vrb_trace.h > > b/drivers/baseband/acc/vrb_trace.h > > index 0bbfdc47d1..c9ae239fec 100644 > > --- a/drivers/baseband/acc/vrb_trace.h > > +++ b/drivers/baseband/acc/vrb_trace.h > > @@ -11,7 +11,7 @@ extern "C" { > > > > #include <rte_trace_point.h> > > > > -RTE_TRACE_POINT_FP( > > +RTE_TRACE_POINT( > > rte_bbdev_vrb_trace_error, > > RTE_TRACE_POINT_ARGS(uint8_t dev_id, const char *op_string, const > > char *err_string), > > rte_trace_point_emit_u8(dev_id); > > @@ -19,7 +19,7 @@ RTE_TRACE_POINT_FP( > > rte_trace_point_emit_string(err_string); > > ) > > > > -RTE_TRACE_POINT_FP( > > +RTE_TRACE_POINT( > > rte_bbdev_vrb_trace_queue_error, > > RTE_TRACE_POINT_ARGS(uint8_t qg_id, uint8_t aq_id, const char *str), > > rte_trace_point_emit_u8(qg_id); > > Maybe worth expanding in the commit message that from now on, the > trace will be emitted systematically, > i.e. without having to build with RTE_ENABLE_TRACE_FP set? > > It can be done while applying.
Reviewed-by: Maxime Coquelin <[email protected]> > Thanks, > Maxime > > > -- > > 2.34.1 > >
