16/10/2025 10:10, Bruce Richardson: > On Wed, Oct 15, 2025 at 09:41:18PM +0200, Robin Jarry wrote: > > Thomas Monjalon, Oct 15, 2025 at 21:11: > > > 15/10/2025 19:50, Stephen Hemminger: > > >> Minor stuff. > > >> > > >> $ flake8 --max-line-length=100 dpdk-mbuf-history-parser.py > > >> dpdk-mbuf-history-parser.py:14:1: F401 'sys' imported but unused > > >> dpdk-mbuf-history-parser.py:29:27: E203 whitespace before ':' > > > > > > Interesting, thanks. > > > > > > I'm a bit lost about Python linters. > > > I ran black, should I run flake8 + black? something else? > > > > Just black. Flake8 style is completely obsolete. The unused import > > warning is legit though. > > > > We should have a centralized python linter process in DPDK. The main > > issue is that most of the code will not pass as it is :D > > > ... yet! > > For python scripts in DPDK I wouldn't have a major issue about having a > patchset with the results of a black run on them. History tracking of the > python files is not as important as for the C files, since they don't have > that many bug fixes on them to root cause. Once we get everything nicely > formatted then we can mandate proper formatting going forward (and > integrate into CI perhaps).
I fully agree.
