This patch makes several changes to improve the style and of the driver's code by adding comment and line breaks.
Signed-off-by: Amit Bernstein <[email protected]> Signed-off-by: Shai Brandes <[email protected]> Reviewed-by: Yosef Raisman <[email protected]> --- drivers/net/ena/ena_ethdev.c | 7 +++---- drivers/net/ena/ena_ethdev.h | 1 - drivers/net/ena/ena_rss.c | 2 ++ 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index aaa4feb11b..3274ecfb46 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -31,6 +31,8 @@ #define GET_L4_HDR_LEN(mbuf) \ ((rte_pktmbuf_mtod_offset(mbuf, struct rte_tcp_hdr *, \ mbuf->l3_len + mbuf->l2_len)->data_off) >> 4) + +/* return val clamped to the [min, max] range */ #define CLAMP_VAL(val, min, max) \ (RTE_MIN(RTE_MAX((val), (typeof(val))(min)), (typeof(val))(max))) @@ -918,6 +920,7 @@ static inline void ena_indirect_table_release(struct ena_adapter *adapter) adapter->indirect_table = NULL; } } + static int ena_close(struct rte_eth_dev *dev) { struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev); @@ -952,14 +955,10 @@ static int ena_close(struct rte_eth_dev *dev) ena_indirect_table_release(adapter); rte_free(adapter->drv_stats); adapter->drv_stats = NULL; - ena_com_set_admin_running_state(ena_dev, false); - ena_com_rss_destroy(ena_dev); - ena_com_delete_debug_area(ena_dev); ena_com_delete_host_info(ena_dev); - ena_com_abort_admin_commands(ena_dev); ena_com_wait_for_abort_completion(ena_dev); ena_com_admin_destroy(ena_dev); diff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h index 6a3b004653..3a66d79384 100644 --- a/drivers/net/ena/ena_ethdev.h +++ b/drivers/net/ena/ena_ethdev.h @@ -29,7 +29,6 @@ #define ENA_RX_BUF_MIN_SIZE 1400 #define ENA_DEFAULT_RING_SIZE 1024 - #define ENA_MIN_MTU 128 #define ENA_MMIO_DISABLE_REG_READ BIT(0) diff --git a/drivers/net/ena/ena_rss.c b/drivers/net/ena/ena_rss.c index 45578189b9..0af1879dc4 100644 --- a/drivers/net/ena/ena_rss.c +++ b/drivers/net/ena/ena_rss.c @@ -56,6 +56,7 @@ size_t ena_rss_get_indirection_table_size(struct ena_adapter *adapter) adapter->indirect_table_size = (1UL << ena_dev->rss.tbl_log_size); return adapter->indirect_table_size; } + void ena_rss_key_fill(void *key, size_t size) { static bool key_generated; @@ -512,6 +513,7 @@ int ena_rss_configure(struct ena_adapter *adapter) tbl_size = ena_rss_get_indirection_table_size(adapter); if (!tbl_size) return 0; + /* Restart the indirection table. The number of queues could change * between start/stop calls, so it must be reinitialized with default * values. -- 2.17.1
