On Mon, Apr 25, 2016 at 10:13:00PM -0700, Rasesh Mody wrote: > The base driver is the backend module for the QLogic FastLinQ QL4xxxx > 25G/40G CNA family of adapters as well as their virtual functions (VF) > in SR-IOV context. > > The purpose of the base module is to: > - provide all the common code that will be shared between the various > drivers that would be used with said line of products. Flows such as > chip initialization and de-initialization fall under this category. > - abstract the protocol-specific HW & FW components, allowing the > protocol drivers to have clean APIs, which are detached in its > slowpath configuration from the actual Hardware Software Interface(HSI). > > This patch adds a base module without any protocol-specific bits. > I.e., this adds a basic implementation that almost entirely falls under > the first category. > > Signed-off-by: Harish Patil <harish.patil at qlogic.com> > Signed-off-by: Rasesh Mody <rasesh.mody at qlogic.com> > Signed-off-by: Sony Chacko <sony.chacko at qlogic.com> > ---
Checkpatch complains about a few things when I run it, notably this typo: WARNING:TYPO_SPELLING: 'DIDNT' may be misspelled - perhaps 'DIDN'T'? #13900: FILE: drivers/net/qede/base/ecore_hsi_tools.h:913: + DBG_STATUS_DATA_DIDNT_TRIGGER, and a few complaints about: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #223: FILE: drivers/net/qede/base/bcm_osal.c:90: + unsigned socket_id; Regards, /Bruce
