On Thu, Oct 23, 2025 at 08:46:26AM -0700, Stephen Hemminger wrote: > The primary process will start to notify all secondary processes > about pdump changes. The pdump secondary process can just call > rte_pdump_init() and it take care of that. > > Signed-off-by: Stephen Hemminger <[email protected]> > --- > app/pdump/main.c | 4 ++++ > 1 file changed, 4 insertions(+) >
It's weird that the pdump app doesn't call pdump_init, but grep of the source shows indeed it doesn't! Acked-by: Bruce Richardson <[email protected]> > diff --git a/app/pdump/main.c b/app/pdump/main.c > index 1741d7e709..626ba0ce93 100644 > --- a/app/pdump/main.c > +++ b/app/pdump/main.c > @@ -552,6 +552,7 @@ cleanup_pdump_resources(void) > } > > } > + rte_pdump_uninit(); > cleanup_rings(); > } > > @@ -822,6 +823,9 @@ enable_pdump(void) > struct pdump_tuples *pt; > int ret = 0, ret1 = 0; > > + if (rte_pdump_init() < 0) > + rte_exit(EXIT_FAILURE, "pdump init failed\n"); > + > for (i = 0; i < num_tuples; i++) { > pt = &pdump_t[i]; > if (pt->dir == RTE_PDUMP_FLAG_RXTX) { > -- > 2.51.0 >
