No existing code is checking the return value of rte_bitmap_free and other functions like rte_free do not return an int. Change it to just a stub void function.
This was motivated by Coverity warnings about unchecked return value. Signed-off-by: Stephen Hemminger <[email protected]> --- doc/guides/rel_notes/release_25_11.rst | 3 +++ lib/eal/include/rte_bitmap.h | 14 +++----------- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/doc/guides/rel_notes/release_25_11.rst b/doc/guides/rel_notes/release_25_11.rst index c5ba335cfc..4b8e084204 100644 --- a/doc/guides/rel_notes/release_25_11.rst +++ b/doc/guides/rel_notes/release_25_11.rst @@ -220,6 +220,9 @@ API Changes The link type was previously hardcoded to the Ethernet link type in the API. This argument is added to ``rte_pcapng_add_interface``. +* bitmap: Changed the return type of ``rte_bitmap_free()`` to void + for consistency with other free functions. + ABI Changes ----------- diff --git a/lib/eal/include/rte_bitmap.h b/lib/eal/include/rte_bitmap.h index abb102f1d3..5a4a68cc2d 100644 --- a/lib/eal/include/rte_bitmap.h +++ b/lib/eal/include/rte_bitmap.h @@ -280,22 +280,14 @@ rte_bitmap_init_with_all_set(uint32_t n_bits, uint8_t *mem, uint32_t mem_size) } /** - * Bitmap free + * Bitmap free does nothing in current version. * * @param bmp * Handle to bitmap instance - * @return - * 0 upon success, error code otherwise */ -static inline int -rte_bitmap_free(struct rte_bitmap *bmp) +static inline void +rte_bitmap_free(struct rte_bitmap *bmp __rte_unused) { - /* Check input arguments */ - if (bmp == NULL) { - return -1; - } - - return 0; } /** -- 2.51.0
