> From: Thomas Monjalon [mailto:[email protected]] > Sent: Wednesday, 19 November 2025 14.44 > > 19/11/2025 14:19, Morten Brørup: > > > From: Thomas Monjalon [mailto:[email protected]] > > > Sent: Wednesday, 19 November 2025 14.04 > > > > > > After removing callback checks from ethdev fast path, > > > some drivers crashed because tx_pkt_prepare was set to NULL. > > > > > > Some drivers (hns3, ngbe, txgbe) need to use > > > rte_eth_tx_pkt_prepare_dummy > > > when configuring queues. > > > Other drivers (ntnic, softnic) does not need to set tx_pkt_prepare > > > as it was set by eth_dev_set_dummy_fops() called by > > > rte_eth_dev_allocate(). > > > > > > Bugzilla ID: 1834 > > > Fixes: 066f3d9cc21c ("ethdev: remove callback checks from fast > path") > > > > > > Reported-by: Jiawen Wu <[email protected]> > > > Signed-off-by: Thomas Monjalon <[email protected]> > > > --- > > > > Searching for "tx_pkt_prepare = NULL;" finds a few more, but they are > all in driver cleanup functions, so... > > Reviewed-by: Morten Brørup <[email protected]> > > Yes I am working on the cleanup side. > But there is no bug in cleanup, it will be a cleanup of cleanup ;)
Agree. I should have been more clear in my review comment: The ones I found in driver cleanup functions don't cause problems, so I consider this patch complete. > So cleanup will be handled after 25.11 release. >
