On Wed, 3 Dec 2025 13:01:57 +0200
Shani Peretz <[email protected]> wrote:
> Increase str_name buffer size from 16 to 32 bytes to fit the provided
> format. The previous size was insufficient as the format
> string "pkt_pool%i" can produce up to 19 bytes (8 for "pkt_pool",
> up to 10 for integer value, and 1 for null terminator).
>
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample
> application")
> Cc: [email protected]
>
> Signed-off-by: Shani Peretz <[email protected]>
> ---
> examples/ethtool/ethtool-app/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/ethtool/ethtool-app/main.c
> b/examples/ethtool/ethtool-app/main.c
> index 1f011a9321..06605b4202 100644
> --- a/examples/ethtool/ethtool-app/main.c
> +++ b/examples/ethtool/ethtool-app/main.c
> @@ -92,7 +92,7 @@ static void setup_ports(struct app_config *app_cfg, int
> cnt_ports)
> int size_pktpool;
> struct rte_eth_conf cfg_port;
> struct rte_eth_dev_info dev_info;
> - char str_name[16];
> + char str_name[32];
Don't use hard coded constant, instead use RTE_MEMPOOL_NAMESIZE which is
not 32, but 32 - 4 + 1 = 29
