On Wed, 10 Dec 2025 15:01:50 +0000 Kevin Traynor <[email protected]> wrote:
> # Discussion of VLAN offload in PMD > > - Discussion over patch for nbl driver that hard codes a return 0 forJ > vlan_offload_set callback > - https://inbox.dpdk.org/dev/[email protected]/ > - vlan offload is done in software > - Issue is that existing OOT driver does this, so it would break apps vs > in-tree driver if it returned ENOSUP > - For current release, leave code as is > - For future release, consider to do some validation at ethdev level Just to follow up, the underlying problem here was me misreading the code. The driver is doing VLAN offload in software which is fine (it is what virtio does). It does raise the issue of maybe this should be done in ethdev layer so all drivers that don't do HW offload could just be done in software by ethdev. That would make the mbuf consistent across all drivers.
