2016-08-02 08:22, Dai, Wei: > Hi, Thomas, Yigit > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2016-07-28 16:26, Ferruh Yigit: > > > On 7/27/2016 12:27 PM, Wei Dai wrote: > > > > With --lcores 'a-b at c-d', eal_parse_cores() fails because > > > > eal_parse_set() fails due to the next character after lcore set a-b, > > > > which is '@'and not ',' or '\0'. > > > > There is also a right check immediately after this incorrect check. > > > > > > > > Fixes: 53e54bf81700 ("eal: new option --lcores for cpu assignment") > > > > > > > > Signed-off-by: Wei Dai <wei.dai at intel.com> > > > > > > I am not sure if a-b at c-d syntax should be supported. (a-b)@(c-d) is > > > supported and already working. > > > > Agreed. > > > > Series applied, except this last patch 4, thanks > > Sorry, I can't find any document to clarify whether a-b at c-d shoule be > supported. > So I design following case to verify all kinds of combination of - and @. > I tested my patch with --lcores '0-3 at 12-15, 4-7@(8-11), (8-11)@4-7, > (12-15)@(0-3), 16-19, (20-23) ',
OK. So do you agree we can discard this patch and forget this syntax?