On Sat, Mar 21, 2026 at 09:14:18AM -0700, Stephen Hemminger wrote: > On Thu, 19 Mar 2026 17:16:27 +0000 > Bruce Richardson <[email protected]> wrote: > > > On Thu, Mar 19, 2026 at 05:11:37PM +0000, Bruce Richardson wrote: > > > FreeBSD doesn't support multiprocess so skip the pdump unit test which > > > requires multi-process support. > > > > > > Bugzilla ID: 761 (partial fix) > > > Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library") > > > Cc: [email protected] > > > > > > Signed-off-by: Bruce Richardson <[email protected]> > > > --- > > > app/test/test_pdump.c | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/app/test/test_pdump.c b/app/test/test_pdump.c > > > index 824caef2d4..9d1175b4b0 100644 > > > --- a/app/test/test_pdump.c > > > +++ b/app/test/test_pdump.c > > > @@ -5,6 +5,7 @@ > > > #include <unistd.h> > > > #include <stdint.h> > > > #include <limits.h> > > > +#include <sys/utsname.h> > > > > > > #include <ethdev_driver.h> > > > #include <rte_pdump.h> > > > @@ -197,7 +198,12 @@ run_pdump_server_tests(void) > > > int > > > test_pdump(void) > > > { > > > + struct utsname name; > > > int ret = 0; > > > + > > > + if (uname(&name) < 0 || strcmp(name.sysname, "FreeBSD") == 0) > > > + return TEST_SKIPPED; > > > + > > > > Self-NAK, I forgot to update this patch to just use > > "RTE_EXEC_ENV_IS_FREEBSD" instead of calling "uname". Will fix in V2. > > > > > if (rte_eal_process_type() == RTE_PROC_PRIMARY) { > > > printf("IN PRIMARY PROCESS\n"); > > > ret = run_pdump_server_tests(); > > > -- > > > 2.51.0 > > > > > Couldn't there be a common dependency in meson.build > would rather not build tests for platforms that are missing the > secondary_process support.
We probably could engineer something like that, but I actually prefer to keep them as skipped for two reasons: 1. it makes us aware of what tests are not supported rather than having them just silently dropped. 2. for cases like this where we do a runtime check, we at least guarantee that the tests build for the platform
