Several DPDK examples had -Wshadow disabled via no_shadow_cflag in their meson.build files. This series fixes all shadow variable warnings and removes the suppression flag, so that -Wshadow is enabled uniformly across every example.
The fixes fall into three categories: - Renaming function parameters or local variables that shadow globals (most patches) - Removing unused function parameters that duplicated globals (dma, bond, flow_filtering, ipsec-secgw, vhost, qos_sched) - Simply removing no_shadow_cflag where there were no warnings (vm_power_manage, bbdev_app, l2fwd-crypto, l2fwd-event, l3fwd-graph) v2 - fix additional shadow warnings only visible with clang Stephen Hemminger (23): examples/ethtool: resolve shadow variable warnings examples/eventdev_pipeline: resolve shadow variable warning examples/dma: resolve shadow variable warnings examples/packet_ordering: resolve shadow variable warning examples/bond: resolve shadow variable warnings examples/vmdq: resolve shadow variable warning examples/server_node_efd: resolve shadow variable warning examples/flow_filtering: resolve shadowed variable warnings examples/ipsec-secgw: resolve shadowed variable warnings examples/ip_pipeline: resolve shadow variable warning examples/multi_process: resolve shadowed variable warnings examples/vm_power_manage: enable shadow warnings examples/bbdev_app: enable shadow warnings examples/ptpclient: resolve shadow variable warnings examples/vhost: resolve shadow warnings examples/qos_sched: eliminate shadowed variables examples/l2fwd-jobstats: resolve shadowed variable examples/l2fwd-crypto: resolve shadow variable examples/l2fwd-event: resolve shadowed variable examples/l2fwd-keepalive: resolve shadow variable warning examples/l3fwd-graph: resolve shadow variable warning examples/l3fwd: resolve shadow variable warnings examples/l3fwd-power: resolve shadow variable warnings examples/bbdev_app/main.c | 4 +- examples/bbdev_app/meson.build | 1 - examples/bond/main.c | 21 ++- examples/bond/meson.build | 1 - examples/dma/dmafwd.c | 10 +- examples/dma/meson.build | 1 - examples/ethtool/ethtool-app/main.c | 4 +- examples/ethtool/meson.build | 1 - examples/eventdev_pipeline/meson.build | 1 - .../eventdev_pipeline/pipeline_worker_tx.c | 4 +- examples/flow_filtering/flow_skeleton.c | 10 +- examples/flow_filtering/main.c | 4 +- examples/flow_filtering/meson.build | 1 - examples/ip_pipeline/cli.c | 9 +- examples/ip_pipeline/meson.build | 1 - examples/ipsec-secgw/ipsec-secgw.c | 17 +-- examples/ipsec-secgw/ipsec.c | 3 +- examples/ipsec-secgw/ipsec.h | 1 - examples/ipsec-secgw/ipsec_worker.c | 30 ++-- examples/ipsec-secgw/ipsec_worker.h | 4 +- examples/ipsec-secgw/meson.build | 1 - examples/ipsec-secgw/sa.c | 34 ++--- examples/l2fwd-crypto/main.c | 50 +++---- examples/l2fwd-crypto/meson.build | 1 - examples/l2fwd-event/main.c | 15 +- examples/l2fwd-event/meson.build | 1 - examples/l2fwd-jobstats/main.c | 6 +- examples/l2fwd-jobstats/meson.build | 1 - examples/l2fwd-keepalive/main.c | 2 +- examples/l2fwd-keepalive/meson.build | 1 - examples/l3fwd-graph/main.c | 8 +- examples/l3fwd-graph/meson.build | 1 - examples/l3fwd-power/main.c | 12 +- examples/l3fwd-power/meson.build | 1 - examples/l3fwd/l3fwd.h | 2 +- examples/l3fwd/l3fwd_em.c | 32 ++-- examples/l3fwd/l3fwd_em_hlm.h | 8 +- examples/l3fwd/l3fwd_lpm.c | 4 +- examples/l3fwd/l3fwd_route.h | 12 +- examples/l3fwd/main.c | 68 ++++----- examples/l3fwd/meson.build | 1 - .../client_server_mp/mp_server/args.c | 12 +- .../client_server_mp/mp_server/meson.build | 1 - examples/packet_ordering/main.c | 6 +- examples/packet_ordering/meson.build | 1 - examples/ptpclient/meson.build | 1 - examples/ptpclient/ptpclient.c | 138 +++++++++--------- examples/qos_sched/cfg_file.c | 12 +- examples/qos_sched/cfg_file.h | 4 +- examples/qos_sched/init.c | 4 +- examples/qos_sched/meson.build | 1 - examples/server_node_efd/efd_server/args.c | 6 +- .../server_node_efd/efd_server/meson.build | 1 - examples/vhost/main.c | 19 +-- examples/vhost/meson.build | 1 - .../vm_power_manager/guest_cli/meson.build | 1 - examples/vm_power_manager/meson.build | 1 - examples/vmdq/main.c | 8 +- examples/vmdq/meson.build | 1 - 59 files changed, 288 insertions(+), 319 deletions(-) -- 2.53.0
