The '-i' parameter is to set any uncore frequency rather than
min/max value. And the error logs are not clear enough, fix it
by the way.
Fixes: 10db2a5b8724 ("examples/l3fwd-power: add options for uncore frequency")
Cc: [email protected]
Signed-off-by: Huisong Li <[email protected]>
---
doc/guides/sample_app_ug/l3_forward_power_man.rst | 2 +-
examples/l3fwd-power/main.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/doc/guides/sample_app_ug/l3_forward_power_man.rst
b/doc/guides/sample_app_ug/l3_forward_power_man.rst
index 3271bc2154..dc882c5d77 100644
--- a/doc/guides/sample_app_ug/l3_forward_power_man.rst
+++ b/doc/guides/sample_app_ug/l3_forward_power_man.rst
@@ -106,7 +106,7 @@ where,
* -U: optional, sets uncore min/max frequency to maximum value.
-* -i (frequency index): optional, sets uncore frequency to frequency index
value, by setting min and max values to be the same.
+* -i (frequency index): set target frequency for uncore by specified
frequency index.
* --config (port,queue,lcore)[,(port,queue,lcore)]: determines which queues
from which ports are mapped to which cores.
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index ba2be5bf32..45b6697c85 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -1498,7 +1498,7 @@ print_usage(const char *prgname)
" -P: enable promiscuous mode\n"
" -u: set min/max frequency for uncore to minimum value\n"
" -U: set min/max frequency for uncore to maximum value\n"
- " -i (frequency index): set min/max frequency for uncore to
specified frequency index\n"
+ " -i (frequency index): set target frequency for uncore by
specified frequency index\n"
" --config (port,queue,lcore): rx queues configuration\n"
" --eth-link-speed: force link speed\n"
" --cpu-resume-latency LATENCY: set CPU resume latency to
control C-state selection,"
@@ -1582,7 +1582,7 @@ parse_uncore_options(enum uncore_choice choice, const
char *argument)
ret = rte_power_uncore_freq_min(pkg, die);
if (ret == -1) {
RTE_LOG(INFO, L3FWD_POWER,
- "Unable to set the uncore min/max to
minimum uncore frequency value for pkg %02u die %02u\n"
+ "Unable to set the uncore frequency to
minimum value for pkg %02u die %02u\n"
, pkg, die);
return ret;
}
@@ -1590,7 +1590,7 @@ parse_uncore_options(enum uncore_choice choice, const
char *argument)
ret = rte_power_uncore_freq_max(pkg, die);
if (ret == -1) {
RTE_LOG(INFO, L3FWD_POWER,
- "Unable to set uncore min/max to
maximum uncore frequency value for pkg %02u die %02u\n"
+ "Unable to set uncore frequency to
maximum value for pkg %02u die %02u\n"
, pkg, die);
return ret;
}
@@ -1611,7 +1611,7 @@ parse_uncore_options(enum uncore_choice choice, const
char *argument)
ret = rte_power_set_uncore_freq(pkg, die,
frequency_index);
if (ret == -1) {
RTE_LOG(INFO, L3FWD_POWER,
- "Unable to set min/max uncore index
value for pkg %02u die %02u\n",
+ "Unable to set specified frequency
index for pkg %02u die %02u\n",
pkg, die);
return ret;
}
--
2.33.0
