On Wed, May 20, 2026 at 03:50:34PM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:[email protected]] > > Sent: Wednesday, 20 May 2026 09.45 > PATCH 0/8] remove use of rte_memcpy from net/intel > > > > On Tue, May 19, 2026 at 12:43:32PM -0700, Stephen Hemminger wrote: > > > On Tue, 19 May 2026 16:05:57 +0000 > > > Bruce Richardson <[email protected]> wrote: > > > > > > > This RFC proposed to replace all instances of rte_memcpy in Intel > > > > (and former-Intel) net drivers with just regular memcpy. This is > > > > done on the basis that the memcpy use is not datapath, but is used > > > > for flow configuration, virt-channel (to firmware or PF) messaging > > > > and other control path functions. > > > > > > Makes sense. You might also want to look for where structure > > > assignment can be used instead of memcpy. Keeping data types > > > is a good thing. > > > > Yes, it would be nice to use in places. However, it's not a mechanical > > change so I've not taken the time to do the analysis. Just a quick set > > of sed replacements for this RFC. > > If you consider structure assignment, look out for fixed-size structures > ending with field[1]; they are really (ill defined) flex-arrays. >
Yep, they were mentioned in a previous discussion on-list with Anatoly too. Three is always more cleanup to be done! :-)
