Now that the cpufreq framework validates the lcore ID using rte_lcore_is_eal_managed() before dispatching to any driver, each individual cpufreq driver no longer needs its own range check against RTE_MAX_LCORE.
Remove the duplicated lcore ID checks from the cppc cpufreq driver ops. Signed-off-by: Huisong Li <[email protected]> --- drivers/power/cppc/cppc_cpufreq.c | 65 ------------------------------- 1 file changed, 65 deletions(-) diff --git a/drivers/power/cppc/cppc_cpufreq.c b/drivers/power/cppc/cppc_cpufreq.c index 3cd4165c83..529f68e574 100644 --- a/drivers/power/cppc/cppc_cpufreq.c +++ b/drivers/power/cppc/cppc_cpufreq.c @@ -346,12 +346,6 @@ power_cppc_cpufreq_init(unsigned int lcore_id) return -1; } - if (lcore_id >= RTE_MAX_LCORE) { - POWER_LOG(ERR, "Lcore id %u can not exceeds %u", - lcore_id, RTE_MAX_LCORE - 1U); - return -1; - } - pi = &lcore_power_info[lcore_id]; exp_state = POWER_IDLE; /* The power in use state works as a guard variable between @@ -429,11 +423,6 @@ power_cppc_cpufreq_exit(unsigned int lcore_id) struct cppc_power_info *pi; uint32_t exp_state; - if (lcore_id >= RTE_MAX_LCORE) { - POWER_LOG(ERR, "Lcore id %u can not exceeds %u", - lcore_id, RTE_MAX_LCORE - 1U); - return -1; - } pi = &lcore_power_info[lcore_id]; exp_state = POWER_USED; /* The power in use state works as a guard variable between @@ -479,11 +468,6 @@ power_cppc_cpufreq_freqs(unsigned int lcore_id, uint32_t *freqs, uint32_t num) { struct cppc_power_info *pi; - if (lcore_id >= RTE_MAX_LCORE) { - POWER_LOG(ERR, "Invalid lcore ID"); - return 0; - } - if (freqs == NULL) { POWER_LOG(ERR, "NULL buffer supplied"); return 0; @@ -502,22 +486,12 @@ power_cppc_cpufreq_freqs(unsigned int lcore_id, uint32_t *freqs, uint32_t num) uint32_t power_cppc_cpufreq_get_freq(unsigned int lcore_id) { - if (lcore_id >= RTE_MAX_LCORE) { - POWER_LOG(ERR, "Invalid lcore ID"); - return RTE_POWER_INVALID_FREQ_INDEX; - } - return lcore_power_info[lcore_id].curr_idx; } int power_cppc_cpufreq_set_freq(unsigned int lcore_id, uint32_t index) { - if (lcore_id >= RTE_MAX_LCORE) { - POWER_LOG(ERR, "Invalid lcore ID"); - return -1; - } - return set_freq_internal(&(lcore_power_info[lcore_id]), index); } @@ -526,11 +500,6 @@ power_cppc_cpufreq_freq_down(unsigned int lcore_id) { struct cppc_power_info *pi; - if (lcore_id >= RTE_MAX_LCORE) { - POWER_LOG(ERR, "Invalid lcore ID"); - return -1; - } - pi = &lcore_power_info[lcore_id]; if (pi->curr_idx + 1 == pi->nb_freqs) return 0; @@ -544,11 +513,6 @@ power_cppc_cpufreq_freq_up(unsigned int lcore_id) { struct cppc_power_info *pi; - if (lcore_id >= RTE_MAX_LCORE) { - POWER_LOG(ERR, "Invalid lcore ID"); - return -1; - } - pi = &lcore_power_info[lcore_id]; if (pi->curr_idx == 0 || (pi->curr_idx == 1 && pi->turbo_available && !pi->turbo_enable)) @@ -561,11 +525,6 @@ power_cppc_cpufreq_freq_up(unsigned int lcore_id) int power_cppc_cpufreq_freq_max(unsigned int lcore_id) { - if (lcore_id >= RTE_MAX_LCORE) { - POWER_LOG(ERR, "Invalid lcore ID"); - return -1; - } - /* Frequencies in the array are from high to low. */ if (lcore_power_info[lcore_id].turbo_available) { if (lcore_power_info[lcore_id].turbo_enable) @@ -585,11 +544,6 @@ power_cppc_cpufreq_freq_min(unsigned int lcore_id) { struct cppc_power_info *pi; - if (lcore_id >= RTE_MAX_LCORE) { - POWER_LOG(ERR, "Invalid lcore ID"); - return -1; - } - pi = &lcore_power_info[lcore_id]; /* Frequencies in the array are from high to low. */ @@ -601,11 +555,6 @@ power_cppc_turbo_status(unsigned int lcore_id) { struct cppc_power_info *pi; - if (lcore_id >= RTE_MAX_LCORE) { - POWER_LOG(ERR, "Invalid lcore ID"); - return -1; - } - pi = &lcore_power_info[lcore_id]; return pi->turbo_enable; @@ -616,11 +565,6 @@ power_cppc_enable_turbo(unsigned int lcore_id) { struct cppc_power_info *pi; - if (lcore_id >= RTE_MAX_LCORE) { - POWER_LOG(ERR, "Invalid lcore ID"); - return -1; - } - pi = &lcore_power_info[lcore_id]; if (pi->turbo_available) @@ -652,11 +596,6 @@ power_cppc_disable_turbo(unsigned int lcore_id) { struct cppc_power_info *pi; - if (lcore_id >= RTE_MAX_LCORE) { - POWER_LOG(ERR, "Invalid lcore ID"); - return -1; - } - pi = &lcore_power_info[lcore_id]; pi->turbo_enable = 0; @@ -680,10 +619,6 @@ power_cppc_get_capabilities(unsigned int lcore_id, { struct cppc_power_info *pi; - if (lcore_id >= RTE_MAX_LCORE) { - POWER_LOG(ERR, "Invalid lcore ID"); - return -1; - } if (caps == NULL) { POWER_LOG(ERR, "Invalid argument"); return -1; -- 2.33.0
