RE: [PATCH v4 09/20] net/txgbe: fix link flow control config for Sapphire

[Zaiyu Wang]

> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Monday, May 18, 2026 7:46 AM
> To: Zaiyu Wang <zaiyuw...@trustnetic.com>; Zaiyu Wang
> <zaiyuw...@trustnetic.com>
> Cc: dev@dpdk.org; sta...@dpdk.org; Jiawen Wu <jiawe...@trustnetic.com>;
> Ferruh Yigit <ferruh.yi...@amd.com>; dev@dpdk.org; sta...@dpdk.org; Jiawen
> Wu <jiawe...@trustnetic.com>; Ferruh Yigit <ferruh.yi...@amd.com>
> Subject: Re: [PATCH v4 09/20] net/txgbe: fix link flow control config for 
> Sapphire
> 
> On Mon, 11 May 2026 18:35:51 +0800
> Zaiyu Wang <zaiyuw...@trustnetic.com> wrote:
> 
> > SP chips have a hardware bug preventing XON flow control support, so
> > the driver disables it.
> >
> > Fixes: 69ce8c8a4ce3 ("net/txgbe: support flow control")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Zaiyu Wang <zaiyuw...@trustnetic.com>
> > ---
> 
> Comment vs code mismatch
> 
> 
> # Review of Patch 9/20: net/txgbe: fix link flow control config for Sapphire
> 
> ## Errors
> 
> None.
> 
> ## Warnings
> 
> ### W1: Conditional logic inverted (line 1042-1043)
Fixed.

 
> ### W2: Inconsistent capitalization in comment (line 1042)
Fixed.