Hi Yuanhan,
> -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Monday, February 1, 2016 10:06 AM > To: Lu, Wenzhuo > Cc: Qiu, Michael; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and forwarding on > Intel X550 NIC > > On Mon, Feb 01, 2016 at 01:56:32AM +0000, Lu, Wenzhuo wrote: > > Hi Yuanhan, > > > > > -----Original Message----- > > > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > > > Sent: Monday, February 1, 2016 9:40 AM > > > To: Lu, Wenzhuo > > > Cc: Qiu, Michael; dev at dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and > > > forwarding on Intel X550 NIC > > > > > > On Mon, Feb 01, 2016 at 01:04:52AM +0000, Lu, Wenzhuo wrote: > > > > Hi, > > > > > > > > > -----Original Message----- > > > > > From: Qiu, Michael > > > > > Sent: Friday, January 29, 2016 3:16 PM > > > > > To: Lu, Wenzhuo; dev at dpdk.org > > > > > Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and > > > > > forwarding on Intel X550 NIC > > > > > > > > > > Hi, Wenzhuo > > > > > > > > > > Better to explain what E-tag is, so that reviewers could known it. > > > > Yes, it's better. But not sure where should I add this info. In > > > > release note or just > > > cover letter? Any suggestion? Thanks. > > > > > > It should be done in the first patch introduced E-tag, so that it > > > will be in the git log history. And of course, it does no harm at > > > all to mention (briefly) it again in cover letter, so that > > > reviewer/maintainer has a brief understanding of your whole patchset > > > first. > > > > > > --yliu > > Thanks for the suggestion! > > Welcome! Another side note is that, as suggested (and asked) by Thomas, > release note should not be done in a standalone patch, but instead, in the > patch > that enables it. Which is to say, you should squash patch 8 to patch 7 here. > > --yliu Thanks for the reminder!
