On Tue, Jun 23, 2026 at 6:35 PM Patrick Robb <[email protected]> wrote:
> Looks like your patch is failing some of the checks on patchwork, > including doc build: > https://github.com/ovsrobot/dpdk/actions/runs/27789008643 > > Remember to run a doc build locally before sending any patches: > > meson setup build > ninja -C build doc > > I will resolve this and send a patch out shortly. Otherwise, please provide a little more info regarding your info. So, you > have updated some of the dependencies used in the dts check format script. > I think what I see from a quick look that is relevant is: > > -mypy = "^1.13.0" > +mypy = "^2.1.0" > toml = "^0.10.2" > -ruff = "^0.8.1" > -types-paramiko = "^3.5.0.20240928" > +ruff = "^0.15.16" > +types-paramiko = "^4.0.0.20260518" > types-invoke = "^2.0.0.10" > -types-pyyaml = "^6.0.12.20240917" > +types-pyyaml = "^6.0.12.20260518" > > What is being done broadly? All dependencies covered by poetry are being > updated? or just the subset included in format checks? Are dependencies > being brought to current latest or something different? > Overall, only the dependencies being used by the dts-check-format.sh script were updated. They were brought to the latest versions that were compatible with each other. This allows for more rigorous format checking, as new errors surfaced once the tool versions were updated. > > I remember Thomas mentioning that DTS was not checking the > dts-check-format.sh at DPDK Summit and that confused me. Perhaps he is > running DTS and dts-check-format.sh outside of poetry (which we have said > is okay to do) and he is on newer versions of the formatting dependencies > than what we currently have committed to the poetry.lock. > The lab was notified by Thomas about the following: "About DTS, I think you are running an old version of the tools used in devtools/dts-check-format.sh. When I run it, I have a lot of warnings. We should fix them in DTS and then update the tools in the lab." This may be what he was referring to at the DPDK summit. When running on poetry it uses the older tool versions, to which none of the errors show up. When running outside of poetry, it most likely uses the newer tool versions which causes the underlying errors to appear. Thanks, Koushik
