Hello, Thanks for working on this issue.
On Sun, 28 Jun 2026 at 17:27, Weijun Pan <[email protected]> wrote: > > From: Weijun Pan <[email protected]> > > The queue storage allocation and free helpers are implemented as macros > which declare local variables in the caller scope. This can cause shadow > warnings when -Wshadow is enabled. > > Convert them to static inline functions to avoid macro-local variable > scope issues without changing behavior. > > Bugzilla ID: 1744 This bugzilla is about compiling with -Wshadow. The proposed fix is partial. As I reported in my previous mail, enabling -Wshadow after the current patch still shows many build warnings in drivers/bus/fslmc/qbman/qbman_portal.c. https://inbox.dpdk.org/dev/cajfav8w-vqjb6jm0kgavp1rjkyuuwiba6_seocdwmx47rzm...@mail.gmail.com/ Could you work on a complete fix so the bz can be closed? > Fixes: 12d98eceb8ac ("bus/fslmc: enhance QBMAN DQ storage logic") > Cc: [email protected] > Cc: [email protected] Afaics, nothing is broken in the current code, why do we *need* to backport the change? > Signed-off-by: Weijun Pan <[email protected]> -- David Marchand
