On device reset, GVE skips describe_device functionality, as the device
is not expected to change on a reset. However, before skipping the
describe_device functionality, GVE still sets the ring sizes to their
default values. This effectively removes the ability to create queues
with higher-than-default descriptor counts after a reset.
Fix this behavior by only setting the default ring size bounds is
describe_device is being executed.
Fixes: 1bf64edce3c4 ("net/gve: add reset path")
Cc: [email protected]
Signed-off-by: Joshua Washington <[email protected]>
Reviewed-by: Jasper Tran O'Leary <[email protected]>
---
drivers/net/gve/gve_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
index f73784a109..c990920a4d 100644
--- a/drivers/net/gve/gve_ethdev.c
+++ b/drivers/net/gve/gve_ethdev.c
@@ -1579,12 +1579,12 @@ gve_init_priv(struct gve_priv *priv, bool
skip_describe_device)
goto free_adminq;
}
- /* Set default descriptor counts */
- gve_set_default_ring_size_bounds(priv);
-
if (skip_describe_device)
goto setup_device;
+ /* Set default descriptor counts */
+ gve_set_default_ring_size_bounds(priv);
+
/* Get the initial information we need from the device */
err = gve_adminq_describe_device(priv);
if (err) {
--
2.55.0.rc0.799.gd6f94ed593-goog
