2016-02-04 00:41, Zhang, Helin: > From: Julien Meunier [mailto:julien.meunier at 6wind.com] > > INFO log level is used in order to keep code homogeneity: > > i40e_vsi_config_vlan_stripping or i40e_dev_init_vlan use this log level > > during > > failure for example. > > > > Tell me if ERR log level for VLAN filtering issue must be set. > There is a failure, and may result in uncertain behaviors which cannot be > ignored. > I'd suggest to use ERR but not INFO, though I am not so confident on that. > Could Thomas help give some guidance on that?
Helin, about i40e internals, I follow your guidance :) If you consider it as a real error, yes we must log an error. About code homogeneity, Julien seems to have seen some errors in the driver which should be logged as such, right? It may be a separate effort to fix them. Thanks
