On Fri, Feb 05, 2016 at 03:28:37PM +0900, Tetsuya Mukawa wrote: > On 2016/02/04 20:17, Ferruh Yigit wrote: > > On Thu, Feb 04, 2016 at 04:26:31PM +0900, Tetsuya Mukawa wrote: > > > > Hi Tetsuya, > > > >> The patch introduces a new PMD. This PMD is implemented as thin wrapper > >> of librte_vhost. It means librte_vhost is also needed to compile the PMD. > >> The vhost messages will be handled only when a port is started. So start > >> a port first, then invoke QEMU. > >> > >> The PMD has 2 parameters. > >> - iface: The parameter is used to specify a path to connect to a > >> virtio-net device. > >> - queues: The parameter is used to specify the number of the queues > >> virtio-net device has. > >> (Default: 1) > >> > >> Here is an example. > >> $ ./testpmd -c f -n 4 --vdev 'eth_vhost0,iface=/tmp/sock0,queues=1' -- -i > >> > >> To connect above testpmd, here is qemu command example. > >> > >> $ qemu-system-x86_64 \ > >> <snip> > >> -chardev socket,id=chr0,path=/tmp/sock0 \ > >> -netdev vhost-user,id=net0,chardev=chr0,vhostforce,queues=1 \ > >> -device virtio-net-pci,netdev=net0,mq=on > >> > >> Signed-off-by: Tetsuya Mukawa <mukawa at igel.co.jp> > > Please find some more comments, mostly minor nits, > > > > please feel free to add my ack for next version of this patch: > > Acked-by: Ferruh Yigit <ferruh.yigit at intel.com> > > > > <...> > >> diff --git a/drivers/net/vhost/rte_eth_vhost.c > >> b/drivers/net/vhost/rte_eth_vhost.c > >> new file mode 100644 > >> index 0000000..b2305c2 > >> --- /dev/null > >> +++ b/drivers/net/vhost/rte_eth_vhost.c > > <...> > >> + > >> +struct pmd_internal { > >> + TAILQ_ENTRY(pmd_internal) next; > >> + char *dev_name; > >> + char *iface_name; > >> + uint8_t port_id; > > You can also get rid of port_id too, if you keep list of rte_eth_dev. > > But this is not so important, keep as it is if you want to. > > Thank you so much for checking and good suggestions. > I will follow your comments without below.
You might need update the MAINTAINERS file as well. --yliu