On Mon, Aug 10, 2026 at 10:04:20AM +0800, Hailin Xu wrote:
> Signed-off-by: Hailin Xu <[email protected]>
> ---
>  doc/guides/nics/ice.rst | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)

Acked-by: Bruce Richardson <[email protected]>

Some suggested tweaks below, which I will make on apply, thanks.

> 
> diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst
> index b671422ad7..e908b11f6b 100644
> --- a/doc/guides/nics/ice.rst
> +++ b/doc/guides/nics/ice.rst
> @@ -13,6 +13,7 @@ the following controllers,
>  - Intel Ethernet Connection E823
>  - Intel Ethernet Connection E825
>  - Intel Ethernet Controller E830
> +- Intel Ethernet Controller E835
>  
>  Linux Prerequisites
>  -------------------
> @@ -58,16 +59,16 @@ The full list of in-tree and out-of-tree Linux kernel 
> drivers from kernel.org
>  and Linux distributions that were tested and verified
>  are listed in the Tested Platforms section of the Release Notes for each 
> release.
>  
> -=====  =============  ===========  =========  ============  =======  =======
> -DPDK   Kernel Driver  Default DDP  COMMS DDP  Wireless DDP  E810 FW  E830 FW
> -=====  =============  ===========  =========  ============  =======  =======
> -26.07     2.6.6         1.3.59      1.3.63       1.3.28      5.0      2.10
> -26.03     2.4.5         1.3.53      1.3.61       1.3.25      4.91     1.20
> -25.11     2.3.14        1.3.43      1.3.55       1.3.25      4.9      1.11
> +=====  =============  ===========  =========  ============  =======  
> ============
> +DPDK   Kernel Driver  Default DDP  COMMS DDP  Wireless DDP  E810 FW  
> E830&E835 FW

I think it might be better to write as "E830/E835" rather than using an
"&". It seems a bit easier to read.

> +=====  =============  ===========  =========  ============  =======  
> ============
> +26.07     2.6.6         1.3.59      1.3.63       1.3.28      5.0        2.10
> +26.03     2.4.5         1.3.53      1.3.61       1.3.25      4.91       1.20
> +25.11     2.3.14        1.3.43      1.3.55       1.3.25      4.9        1.11

I don't think it's worth adding an extra space to these numbers, increasing
the diff unnecessarily. It's only really the headers which change.

>  24.11     1.15.4        1.3.36      1.3.46       1.3.14      4.6
>  23.11     1.13.7        1.3.36      1.3.46       1.3.14      4.4
>  22.11     1.10.1        1.3.30      1.3.37       1.3.10      4.1
> -=====  =============  ===========  =========  ============  =======  =======
> +=====  =============  ===========  =========  ============  =======  
> ============
>  
>  
>  Dynamic Device Personalization (DDP) package loading
> -- 
> 2.34.1
> 

Reply via email to