On Tue, Feb 9, 2016 at 4:52 AM, Tetsuya Mukawa <mukawa at igel.co.jp> wrote: > On 2016/02/07 16:48, David Marchand wrote: > One more legacy_virtio_resource_init() is defined like below. > > #ifdef RTE_EXEC_ENV_LINUXAPP > <snip> > #else > <snip> > static int > legacy_virtio_resource_init(struct rte_pci_device *pci_dev __rte_unused) > { > /* no setup required */ > return 0; > } > #endif > > Should we change this also?
Yes, I noticed this while doing the patches but forgot to update ... Thanks. In the end, I think that we end up with common code in this case for both bsd and linux. The only thing remaining in virtio that depends on "#ifdef os" is the msix detection. I do not have time to look at this, so I suppose this will have to wait. -- David Marchand