Most rte_flow parsers in DPDK suffer from huge implementation complexity because even though 99% of what people use rte_flow parsers for is parsing protocol graphs, no parser is written explicitly as a graph. This patchset attempts to suggest a viable model to build rte_flow parsers as graphs, by offering a lightweight header only library to build rte_flow parsering graphs without too much boilerplate and complexity.
Most of the patchset is about Intel drivers, but they are meant as reimplementations as well as examples for the rest of the community to assess how to build parsers using this new infrastructure. I expect the first two patches will be of most interest to non-Intel reviewers, as they deal with building two reusable parser architecture pieces. The first piece is a new flow graph helper in ethdev. Its purpose is deliberately narrow: it targets the protocol-graph part of rte_flow pattern parsing, where drivers walk packet headers and validate legal item sequences and parameters. That does not cover all possible rte_flow features, especially more exotic flow items, but it does cover a large and widely shared part of what existing drivers need to do. Or, to put it in other words, the only flow items this infrastructure *doesn't* cover is things that do not lend themselves well to be parsed as a graph of protocol headers (e.g. conntrack items). Everything else should be covered or cover-able. In practice, just about all drivers will benefit from graph parsing as all but one of them implement only the protocol stack parts, which are the ones targeted by the graph helper. The second piece is a reusable flow engine framework for Intel Ethernet drivers. This is kept Intel-local because I do not feel it is even appropriate to define such a framework for all drivers to use in the first place. Even so, the intent is to establish a cleaner parser architecture with a defined interaction model, explicit memory ownership rules, locking, initialization sequence, implementations of rte_flow API entry points, flow replay and memory cleanup, and engine definitions that do not block secondary-process-safe usage. It is my hope that this would serve as a model for other drivers to follow, expand on, rework, and improve, so that maybe down the line we *might* have a common rte_flow infrastructure for drivers to use. Most of the rest of the series is parser reimplementation, but that is mainly the vehicle for demonstrating and validating those two pieces. ixgbe and i40e are wired into the new common parsing path, and their existing parsers are migrated incrementally to the graph-based model. Besides reducing ad hoc parser code, this also makes validation more explicit and more consistent. In a few places that means invalid inputs that were previously ignored, deferred, or interpreted loosely are now rejected earlier and more strictly, without any increase in code complexity (in fact, with marked *decrease* of it!). v1 -> v2: - Renamed `rte_flow_graph` to `flow_graph` - Addressed some comments from Stephen's AI review - Removed the rte_flow_conv hack on account of Stephen's upcoming patches making the API stable - Split up "flow_install" into register and install steps, which enabled two new use cases: cleanup of memory without HW deregistration, and flow configuration replay after `dev_start` - More aggressive refactoring of all engines on account of new pieces of infrastructure, which allows for reduced complexity of implementation - Combined i40e tunnel engine patches into one patch - Added i40e flow director refactoring to cleanly support the new API as well as the legacy PMD-specific API RFC -> v1: - Fixed a lot of bugs, concurrency issues, and init/uninit sequence problems in Intel common flow engine implementation - Fixed a few copypaste errors in various engines - Improved comment documentation and flow engine docs Anatoly Burakov (19): ethdev: add flow graph API net/intel/common: add flow engines infrastructure net/intel/common: add utility functions net/ixgbe: add support for common flow parsing net/ixgbe: reimplement ethertype parser net/ixgbe: reimplement syn parser net/ixgbe: reimplement L2 tunnel parser net/ixgbe: reimplement ntuple parser net/ixgbe: reimplement security parser net/ixgbe: reimplement FDIR parser net/ixgbe: reimplement hash parser net/ixgbe: advertise flow keep capability net/i40e: add support for common flow parsing net/i40e: reimplement ethertype parser net/i40e: refactor FDIR engine infrastructure net/i40e: reimplement FDIR parser net/i40e: reimplement tunnel parsers net/i40e: reimplement hash parser net/i40e: advertise flow keep capability doc/guides/prog_guide/ethdev/flow_graph.rst | 748 +++ doc/guides/prog_guide/ethdev/index.rst | 1 + doc/guides/rel_notes/release_26_11.rst | 5 + drivers/net/intel/common/flow_engine.h | 1613 +++++++ drivers/net/intel/common/flow_util.h | 183 + drivers/net/intel/i40e/i40e_ethdev.c | 996 +--- drivers/net/intel/i40e/i40e_ethdev.h | 261 +- drivers/net/intel/i40e/i40e_fdir.c | 983 ++-- drivers/net/intel/i40e/i40e_flow.c | 4185 +---------------- drivers/net/intel/i40e/i40e_flow.h | 30 + drivers/net/intel/i40e/i40e_flow_ethertype.c | 348 ++ drivers/net/intel/i40e/i40e_flow_fdir.c | 2056 ++++++++ drivers/net/intel/i40e/i40e_flow_hash.c | 1441 ++++++ drivers/net/intel/i40e/i40e_flow_tunnel.c | 1590 +++++++ drivers/net/intel/i40e/i40e_hash.c | 1208 +---- drivers/net/intel/i40e/i40e_hash.h | 19 +- drivers/net/intel/i40e/meson.build | 4 + drivers/net/intel/i40e/rte_pmd_i40e.c | 4 +- drivers/net/intel/ixgbe/ixgbe_ethdev.c | 1002 +--- drivers/net/intel/ixgbe/ixgbe_ethdev.h | 246 +- drivers/net/intel/ixgbe/ixgbe_fdir.c | 304 +- drivers/net/intel/ixgbe/ixgbe_flow.c | 3213 +------------ drivers/net/intel/ixgbe/ixgbe_flow.h | 27 + .../net/intel/ixgbe/ixgbe_flow_ethertype.c | 295 ++ drivers/net/intel/ixgbe/ixgbe_flow_fdir.c | 1703 +++++++ drivers/net/intel/ixgbe/ixgbe_flow_hash.c | 212 + drivers/net/intel/ixgbe/ixgbe_flow_l2tun.c | 317 ++ drivers/net/intel/ixgbe/ixgbe_flow_ntuple.c | 597 +++ drivers/net/intel/ixgbe/ixgbe_flow_security.c | 537 +++ drivers/net/intel/ixgbe/ixgbe_flow_syn.c | 312 ++ drivers/net/intel/ixgbe/ixgbe_ipsec.c | 359 +- drivers/net/intel/ixgbe/ixgbe_ipsec.h | 50 +- drivers/net/intel/ixgbe/ixgbe_pf.c | 49 +- drivers/net/intel/ixgbe/ixgbe_rxtx.c | 48 +- drivers/net/intel/ixgbe/meson.build | 7 + lib/ethdev/flow_graph.h | 507 ++ lib/ethdev/meson.build | 1 + 37 files changed, 14102 insertions(+), 11359 deletions(-) create mode 100644 doc/guides/prog_guide/ethdev/flow_graph.rst create mode 100644 drivers/net/intel/common/flow_engine.h create mode 100644 drivers/net/intel/common/flow_util.h create mode 100644 drivers/net/intel/i40e/i40e_flow.h create mode 100644 drivers/net/intel/i40e/i40e_flow_ethertype.c create mode 100644 drivers/net/intel/i40e/i40e_flow_fdir.c create mode 100644 drivers/net/intel/i40e/i40e_flow_hash.c create mode 100644 drivers/net/intel/i40e/i40e_flow_tunnel.c create mode 100644 drivers/net/intel/ixgbe/ixgbe_flow.h create mode 100644 drivers/net/intel/ixgbe/ixgbe_flow_ethertype.c create mode 100644 drivers/net/intel/ixgbe/ixgbe_flow_fdir.c create mode 100644 drivers/net/intel/ixgbe/ixgbe_flow_hash.c create mode 100644 drivers/net/intel/ixgbe/ixgbe_flow_l2tun.c create mode 100644 drivers/net/intel/ixgbe/ixgbe_flow_ntuple.c create mode 100644 drivers/net/intel/ixgbe/ixgbe_flow_security.c create mode 100644 drivers/net/intel/ixgbe/ixgbe_flow_syn.c create mode 100644 lib/ethdev/flow_graph.h -- 2.52.0
