On Fri, 9 Oct 2026 16:18:47 +0530
Prashant Gupta <[email protected]> wrote:
> This is the second of four series upstreaming the missing NXP dpaa2
> driver changes. It does not depend on series 1 and can be applied
> independently.
>
> Changes in v8:
> - Address review comments for meter and policing support.
> - Add meter resource cleanup during device close.
> - Add policing capability checks.
> - Validate burst size ranges before hardware programming.
> - Fix software/hardware state consistency on profile/policy updates.
> - Clarify and guard default flow-miss handling.
> - Use standard FDIR reporting for flow-steered packets.
> - Document and gate minimum DPNI version for 24-byte flow keys.
> - Fold parser fixups into originating patches.
> - Remove unused VXLAN offset helper following soft parser removal.
> - Update release notes placement and content.
Although review of S1 was clean and now in next-net, the second part
still has open issues:
Review: [PATCH v8-S2 00/13] net/dpaa2 updates
Applies on top of v7-S1. Most v7 comments are addressed (mtr deinit,
policing check, update ordering, FDIR_ID, key size gating, miss
flow note). Remaining items below.
[PATCH 05/13] net/dpaa2: support meter and policing
Error: the burst size check in dpaa2_mtr_profile_add() is pasted
twice. Remove one copy.
Warning: meter_create still drops meter_lock around
dpaa2_mtr_hw_program(). If control operations can be concurrent,
there is a race here; if not allowed, what is the point of
meter_lock? Either hold it across check, program and insert, or
drop the lock.
Info: fsl_dpni.h removes DPNI_POLICER_OPT_DO_NOT_RESET_COUNTERS but
leaves its comment ("Do NOT reset counters generally for policer
update") and an extra blank line where the _v1 prototype was.
Remove both.
Release notes (05/13, 07/13)
Error: not changed from v7. The "Updated NXP DPAA2 net driver"
block is still above the "New Features" heading, duplicates the
existing "Updated NXP DPAA2 ethernet driver" entry, and still lists
"Tx queue based flow control" and "software parser based packet
dump", which this series does not add (12/13 removes the soft
parser). Move the meter and miss flow bullets into the existing
entry under New Features:
* **Updated NXP DPAA2 ethernet driver.**
...
* Added support for traffic metering and policing (rte_mtr API).
* Removed ``DPAA2_FLOW_CONTROL_MISS_FLOW`` environment variable.
Use the rte_flow API to steer unmatched frames.
[PATCH 10/13] net/dpaa2: restructure dpaa2 parser processing
Warning: the new code in dpaa2_rxtx.c is indented with spaces
(about 100 lines, e.g. dpaa2_dev_rx_mbuf_sched_set()). Use tabs.
Warning: the commit message is stale. It still says "Restore Rx
timestamp" and "Drop RTE_MBUF_F_RX_FDIR", but timestamp is already
handled at 08/13 and the code now sets RX_FDIR | RX_FDIR_ID. Drop
both bullets. Also rename dpaa2_dev_rx_mbuf_sched_set(), it no
longer calls rte_mbuf_sched_set(); dpaa2_dev_rx_flc_info() or
similar.
