From: Kishore Padmanabha <[email protected]>
Validate the pool index in the pool manager APIs so that it cannot go
out of bounds when setting or getting data from the table-scope pool
manager.
Fixes: 80317ff6adfd ("net/bnxt/tf_core: support Thor2")
Cc: [email protected]
Signed-off-by: Kishore Padmanabha <[email protected]>
Signed-off-by: Mohammad Shuab Siddique <[email protected]>
---
v2:
- Use %u for the new log messages instead of PRIu16, and drop the <inttypes.h>
include that is no longer needed
drivers/net/bnxt/hcapi/cfa_v3/tpm/cfa_tpm.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/net/bnxt/hcapi/cfa_v3/tpm/cfa_tpm.c
b/drivers/net/bnxt/hcapi/cfa_v3/tpm/cfa_tpm.c
index 790b6c7e420..b143d045e15 100644
--- a/drivers/net/bnxt/hcapi/cfa_v3/tpm/cfa_tpm.c
+++ b/drivers/net/bnxt/hcapi/cfa_v3/tpm/cfa_tpm.c
@@ -119,6 +119,12 @@ int cfa_tpm_free(void *tpm, uint16_t pool_id)
return -EINVAL;
}
+ if (pool_id >= ctx->max_pools) {
+ CFA_LOG_ERR("pool_id (%u) out of range (max %u)\n",
+ pool_id, ctx->max_pools);
+ return -EINVAL;
+ }
+
if (ctx->fid_tbl[pool_id] != CFA_INVALID_FID) {
CFA_LOG_ERR("A function (%d) is still using the pool (%d)\n",
ctx->fid_tbl[pool_id], pool_id);
@@ -137,6 +143,12 @@ int cfa_tpm_fid_add(void *tpm, uint16_t pool_id, uint16_t
fid)
return -EINVAL;
}
+ if (pool_id >= ctx->max_pools) {
+ CFA_LOG_ERR("pool_id (%u) out of range (max %u)\n",
+ pool_id, ctx->max_pools);
+ return -EINVAL;
+ }
+
if (!ba_inuse(ctx->pool_ba, pool_id)) {
CFA_LOG_ERR("Pool id (%d) was not allocated\n", pool_id);
return -EINVAL;
@@ -163,6 +175,12 @@ int cfa_tpm_fid_rem(void *tpm, uint16_t pool_id, uint16_t
fid)
return -EINVAL;
}
+ if (pool_id >= ctx->max_pools) {
+ CFA_LOG_ERR("pool_id (%u) out of range (max %u)\n",
+ pool_id, ctx->max_pools);
+ return -EINVAL;
+ }
+
if (!ba_inuse(ctx->pool_ba, pool_id)) {
CFA_LOG_ERR("Pool id (%d) was not allocated\n", pool_id);
return -EINVAL;
--
2.47.3
