Hi, Bruce, > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, February 16, 2016 11:28 PM > To: Chen, Jing D > Cc: Qiu, Michael; Ananyev, Konstantin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] fm10k: optimize legacy TX func > > On Thu, Jan 28, 2016 at 05:45:59PM +0800, Chen Jing D(Mark) wrote: > > From: "Chen Jing D(Mark)" <jing.d.chen at intel.com> > > > > When legacy TX func tries to free a bunch of mbufs, it will free them > > one by one. This change will scan the free list and merge the requests > > in case they belongs to same pool, then free once, which will reduce > > cycles on freeing mbufs. > > > > Signed-off-by: Chen Jing D(Mark) <jing.d.chen at intel.com> > > --- > > doc/guides/rel_notes/release_2_3.rst | 2 + > > drivers/net/fm10k/fm10k_rxtx.c | 59 > ++++++++++++++++++++++++++++----- > > 2 files changed, 52 insertions(+), 9 deletions(-) > > > > diff --git a/doc/guides/rel_notes/release_2_3.rst > > b/doc/guides/rel_notes/release_2_3.rst > > index 99de186..20ce78d 100644 > > --- a/doc/guides/rel_notes/release_2_3.rst > > +++ b/doc/guides/rel_notes/release_2_3.rst > > @@ -3,7 +3,9 @@ DPDK Release 2.3 > > > > New Features > > ------------ > > +* **Optimize fm10k Tx func.** > > > > + * Free multiple mbufs at a time to reduce freeing mbuf cycles. > > > > Is this really a significant enough change to warrant being called out in the > release notes? > Personally, I don't think so, so if you are ok with it, I'll just apply this > patch > without the RN update. > > /Bruce
This change will have some performance gain with legacy TX func. That's why I'd like to add a line in release notes. If you thinks it's not necessary, please kindly remove it.