On 02/18/2016 03:25 PM, Yuanhan Liu wrote:
> On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote:
>> Commit d0cf91303d73 added dependency on librte_net headers to vhost
>> but did not add this to the Makefile, which makes builds
>> non-deterministic. Curiously it is non-parallel build that is
>> consistently broken by this missing dependency, usually it's the other
>> way around, but trying to build without -j(n) fails with:
>
> Yeah, I have confirmed it; I was wondering why I didn't meet such build
> error.
>
>>
>> dpdk/lib/librte_vhost/vhost_rxtx.c:41:20:
>> fatal error: rte_ip.h: No such file or directory
>>
>> Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities")
>> Signed-off-by: Panu Matilainen <pmatilai at redhat.com>
>
> Acked-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>
>
> Thanks.
>
> BTW, please cc me for virtio/vhost patches next time, otherwise, it's
> easily got overlooked: too many emails.
Hmm, I thought I did. Looking more carefully now, I mixed up the patch
author (who was CC'd) with you:
commit d0cf91303d731997945420832ee245b21f292e19
Author: Jijiang Liu <jijiang.liu at intel.com>
I hate it when people call me Paul (commonly happens) just because it
vaguely resembles my name, so I really should do better than this.
Apologies, I'll pay closer attention in the future.
- Panu -
