On Mon, 2 Nov 2026 at 16:28, Thomas Monjalon <[email protected]> wrote: > > System headers may indirectly include linux/stddef.h > before the imported UAPI headers. > Both versions share the _LINUX_STDDEF_H include guard, > so the imported header is then skipped. > > If the system header lacks __counted_by, > its fallback definition in the imported header is not processed, > causing a compilation failure in vfio.h: > > In file included from lib/eal/linux/eal_vfio_cdev.c:14: > kernel/linux/uapi/linux/vfio.h:1524:51: error: > expected ':', ',', ';', '}' or '__attribute__' before '__counted_by' > > Include the imported UAPI headers before the system headers > so their compatibility definitions are available. > > Fixes: d129414711aa ("vfio: introduce cdev mode") > > Signed-off-by: Thomas Monjalon <[email protected]>
Strange we did not hit it earlier, but the fix lgtm. I though I had fixed such issues.. but I probably missed (messed?) the new cdev file. Acked-by: David Marchand <[email protected]> -- David Marchand
