On Mon, 16 Nov 2026 20:20:37 +0300
Mark Bulatov <[email protected]> wrote:

> The function nfp_encode_basic_qdr() takes cpp_tgt as its second argument
> and dest_island as its third. However, the implementation of this function
> implies the opposite: dest_island should be the second argument, and
> cpp_tgt the third.
> 
> nfp_encode_basic_qdr() takes dest_island as its second argument and
> cpp_tgt as its third, but all callers in nfp_encode_basic() pass them
> in the opposite order. As a result nfp_decode_basic() gets the island
> ID as the target, and the island check compares against NFP_CPP_TARGET_QDR
> instead of the requested island.
> 
> Fix this by swapping the arguments.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: e6858e7e7cd3 ("net/nfp: move shared target logic to own file")
> Cc: [email protected]
> 
> Signed-off-by: Mark Bulatov <[email protected]>
> ---

AI complains about the commit message.


[PATCH 2/2] net/nfp: fix wrong argument order in nfp_encode_basic

Warning: the first paragraph of the commit message is wrong and
contradicts the second.
  It says nfp_encode_basic_qdr() takes cpp_tgt second and
  dest_island third. The prototype is (addr, dest_island, cpp_tgt,
  ...), as the second paragraph correctly says. This looks like v1
  text that was left in. Drop the first paragraph:

    nfp_encode_basic_qdr() takes dest_island as its second argument
    and cpp_tgt as its third, but all callers in nfp_encode_basic()
    pass them in the opposite order. As a result nfp_decode_basic()
    gets the island ID as the target, and the island check compares
    against NFP_CPP_TARGET_QDR instead of the requested island.

    Fix this by swapping the arguments.

  The fix matches the Linux nfp driver, where all four callers in
  nfpcore/nfp_target.c already pass (*addr, dest_island, cpp_tgt,
  ...). Saying so in the commit message would help the NFP
  maintainers confirm it.

Reply via email to