Better to use the return value of rte_eth_dev_get_name_by_port() rather than depending on side effect of name being set or not.
Coverity ID: 511674 Signed-off-by: Stephen Hemminger <[email protected]> --- examples/multi_process/hotplug_mp/commands.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/examples/multi_process/hotplug_mp/commands.c b/examples/multi_process/hotplug_mp/commands.c index e84e130b3c..b4cd073a4b 100644 --- a/examples/multi_process/hotplug_mp/commands.c +++ b/examples/multi_process/hotplug_mp/commands.c @@ -35,13 +35,14 @@ cmd_list_parsed(__rte_unused void *parsed_result, cmdline_printf(cl, "list all etherdev\n"); RTE_ETH_FOREACH_DEV(port_id) { - char dev_name[RTE_DEV_NAME_MAX_LEN] = ""; + char dev_name[RTE_DEV_NAME_MAX_LEN]; + int ret; - rte_eth_dev_get_name_by_port(port_id, dev_name, sizeof(dev_name)); - if (strlen(dev_name) > 0) - cmdline_printf(cl, "%d\t%s\n", port_id, dev_name); + ret = rte_eth_dev_get_name_by_port(port_id, dev_name, sizeof(dev_name)); + if (ret == 0) + cmdline_printf(cl, "%u\t%s\n", port_id, dev_name); else - printf("empty dev_name is not expected!\n"); + cmdline_printf(cl, "%u\error - %s\n", port_id, strerror(-ret)); } } -- 2.53.0

