On Wed, 18 Nov 2026 15:11:55 +0000
Bruce Richardson <[email protected]> wrote:
> The IEEE1588 forwarder in test-pmd read a single packet at a time rather
> than using the burst size configuration parameter. This meant that it
> cannot be used with vector driver paths which require a minimum burst
> size for calling the Rx function.
>
> Make the forwarding function respect the configured burst size and only
> process packets one at a time, not Rx them one-at-a-time.
>
> Fixes: af75078fece3 ("first public release")
> Cc: [email protected]
>
> Signed-off-by: Bruce Richardson <[email protected]>
> ---
More detailed AI review had pre-existing observation.
Subject: Re: [PATCH] app/test-pmd: use burst IO for IEEE1588 forwarding
Applies cleanly to main. Rx path change is correct; Tx drop path still
frees the mbuf via common_fwd_stream_transmit().
Info
ieee1588_packet_fwd() returns true only if at least one packet was
forwarded. Other engines (macfwd, iofwd) return true whenever
nb_rx > 0, so busy-cycle accounting counts a burst of rejected
packets as idle here. This matches the old single-packet behaviour,
but with bursts it is simpler to follow the other engines:
nb_rx = common_fwd_stream_receive(fs, pkts_burst,
nb_pkt_per_burst);
for (i = 0; i < nb_rx; i++)
ieee1588_process_packet(fs, pkts_burst[i]);
return nb_rx > 0;
ieee1588_process_packet() could then return void.