On Fri, Feb 19, 2016 at 03:26:36PM +0100, Thomas Monjalon wrote: > 2016-01-29 12:57, Yuanhan Liu: > > Introduce vhost_log_write() helper function to log the dirty pages we > > touched. Page size is harded code to 4096 (VHOST_LOG_PAGE), and each > > log is presented by 1 bit. > > > > Therefore, vhost_log_write() simply finds the right bit for related > > page we are gonna change, and set it to 1. dev->log_base denotes the > > start of the dirty page bitmap. > > > > Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com> > > Signed-off-by: Victor Kaplansky <victork at redhat.com> > > Tested-by: Pavel Fedin <p.fedin at samsung.com> > [...] > > +static inline void __attribute__((always_inline)) > > +vhost_log_write(struct virtio_net *dev, uint64_t addr, uint64_t len) > > lib/librte_vhost/vhost_rxtx.c:59:1: error: unused function 'vhost_log_write'
Oops. This functions was defined in a header file. I then moved it to vhost_rxtx.c, but I forgot to do the compile test :( > I think it's better to squash with the next patch. Yes, and thanks! --yliu