> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Qiu > Sent: Friday, January 29, 2016 1:58 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice > > Currently, ixgbe vf and pf will disable interrupt twice in stop stage and > uninit > stage. It will cause an error: > > testpmd> quit > > Shutting down port 0... > Stopping ports... > Done > Closing ports... > EAL: Error disabling MSI-X interrupts for fd 26 > Done > > Becasue the interrupt already been disabled in stop stage. > Since it is enabled in init stage, better remove from stop stage. > > Fixes: 0eb609239efd ("ixgbe: enable Rx queue interrupts for PF and VF") > > Signed-off-by: Michael Qiu <michael.qiu at intel.com> Acked-by: Helin Zhang <helin.zhang at intel.com>
> --- > v2 --> v1: > fix error in commit log word "interrupte" > > drivers/net/ixgbe/ixgbe_ethdev.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 4c4c6df..a561f8d 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2192,9 +2192,6 @@ ixgbe_dev_stop(struct rte_eth_dev *dev) > /* disable interrupts */ > ixgbe_disable_intr(hw); > > - /* disable intr eventfd mapping */ > - rte_intr_disable(intr_handle); > - > /* reset the NIC */ > ixgbe_pf_reset_hw(hw); > hw->adapter_stopped = 0; > @@ -3898,9 +3895,6 @@ ixgbevf_dev_stop(struct rte_eth_dev *dev) > > ixgbe_dev_clear_queues(dev); > > - /* disable intr eventfd mapping */ > - rte_intr_disable(intr_handle); > - > /* Clean datapath event and queue/vec mapping */ > rte_intr_efd_disable(intr_handle); > if (intr_handle->intr_vec != NULL) { > -- > 1.9.3