On 1/5/2016 10:21 AM, Tan, Jianfeng wrote:
>
>> -----Original Message-----
>> From: Xie, Huawei
>> Sent: Monday, January 4, 2016 9:52 AM
>> To: dev at dpdk.org
>> Cc: Mcnamara, John; Tan, Jianfeng; Xie, Huawei
>> Subject: [PATCH] fix checkpatch errors
>>
>> Signed-off-by: Huawei Xie <huawei.xie at intel.com>
> ...
>> mbuf_poolname_build(sock_id, pool_name, sizeof(pool_name));
>> - return (rte_mempool_lookup((const char *)pool_name));
>> + return rte_mempool_lookup((const char *)pool_name);
> Hi Huawei,
>
> Assume this patch is to solve below error (reported by checkpatch):
> ERROR: return is not a function, parentheses are not required
>
> So maybe above fix is not necessary? Involve more people to discuss.
Yes, Almost all of the 800 errors are check patch errors. The
parentheses for some logic expressions, like return val == 0, return
function, are also removed. At least in this patch, they are not needed.
>
> And please include the error message in the commit message.
>
> Thanks,
> Jianfeng
>
>
