On 2016/01/12 14:46, Tan, Jianfeng wrote: > > Hi Tetsuya, > > >> Hi Jianfeng and Xie, >> >> I guess my implementation and yours have a lot of common code, so I will >> try to rebase my patch on yours. > > We also think so. And before you rebase your code, I think we can rely > on Yuanhan's > struct virtio_pci_ops to make the code structure brief and clear, as > discussed in your > patch's thread, i.e., we both rebase our code according to Yuanhan's > code. Is that OK? >
Yes, I agree with it. Thanks, Tetsuya > >> >> BTW, one thing I need to change your memory allocation way is that >> mmaped address should be under 44bit(32 + PAGE_SHIFT) to work with my >> patch. >> This is because VIRTIO_PCI_QUEUE_PFN register only accepts such address. >> (I may need to add one more EAL parameter like "--mmap-under <address>") > > It makes sense. > > Thanks, > Jianfeng > >> >> Thanks, >> Tetsuya >
