On 2016/01/12 15:59, Yuanhan Liu wrote: > +static int > +virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw) > +{ > + uint8_t pos; > + struct virtio_pci_cap cap; > + int ret; > + > + if (rte_eal_pci_map_device(dev) < 0) { > + PMD_INIT_LOG(DEBUG, "failed to map pci device!"); > + return -1; > + } > +
Do you need to call rte_eal_pci_unmap_device() in somewhere in this file? Anyway, I've reviewed and tested your all patches. And it seems except for it, I guess your patches are good. Thanks, Tetsuya