On 1/27/2016 11:26 AM, Yuanhan Liu wrote: > On Tue, Jan 26, 2016 at 10:30:12AM +0000, Xie, Huawei wrote: >> On 12/3/2015 2:03 PM, Yuanhan Liu wrote: >>> Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com> >>> --- >>> lib/librte_vhost/vhost_rxtx.c | 287 >>> +++++++++++++++++------------------------- >>> 1 file changed, 113 insertions(+), 174 deletions(-) >> Prefer to unroll copy_mbuf_to_desc and your COPY macro. It prevents us > I'm okay to unroll COPY macro. But for copy_mbuf_to_desc, I prefer not > to do that, unless it has a good reason. > >> processing descriptors in a burst way in future. > So, do you have a plan?
I think it is OK. If we need unroll in future, we could do that then. I am open to this. Just my preference. I understand that wrapping makes code more readable. > > --yliu >